Leaves - Cloudy #50
Open
Leaves - Cloudy #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Oct 20, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Cloudy, take a look at my comments and let me know where you have questions. You hit the learning goals here. Well done!
|
|
||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: OofNsquared bc delete_at takes up ALOT of space (so says my tutor) |
There was a problem hiding this comment.
Not space, but time, I understand what you're getting at.
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| #hi chris, this one boggled my mind, dont mind my notes. | ||
| # Time Complexity: OofNsquared *maybe? |
There was a problem hiding this comment.
That's a good idea, it's O(n * m) where n is the number of strings and m is the length of the strings.
| # Space Complexity: ? | ||
| #hi chris, this one boggled my mind, dont mind my notes. | ||
| # Time Complexity: OofNsquared *maybe? | ||
| # Space Complexity: OofN |
There was a problem hiding this comment.
It's probably simpler just to put O(n) ok?
You're right where n is the number of letters in a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.