Branches - Linnea #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Oct 9, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Thanks for getting this in. Take a look at my comments and let me know if you have any questions. Some things to work on here.
Comment on lines
+12
to
+14
| if list[i] != i | ||
| new_list << list[i] | ||
| end |
There was a problem hiding this comment.
This is only not adding elements if they are not equal to their index, which won't work in all cases.
Consider:
it "will remove duplicates for even longer arrays " do
expect(remove_duplicates([1, 1, 1, 1, 1, 2, 2, 3, 3, 4, 4, 4, 4, 4])).must_equal [1, 2, 3, 4]
end|
|
||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n^2) |
There was a problem hiding this comment.
This is actually O(nm) where m is the length of the shortest word.
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n^2) | ||
| # Space Complexity: O(n) |
There was a problem hiding this comment.
Given the above space complexity is O(m)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.