Added longest prefix, needs work to pass test #46
Conversation
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Well both methods aren't working. If you have time lets sit down and look at things a bit. Your 1st method remove_duplicates is close to working, while longest prefix has more issues. See my comments and see what you can work out.
|
|
||
| while list.length >= i | ||
| if compare_to == list[i] | ||
| list.delete_at(list[i]) |
There was a problem hiding this comment.
delete_at takes an index number as an argument not an element. So that's why this isn't working.
delete_at also shifts each subsequent element over one index so it's an O(n) method. Since it's nested inside a loop which runs n times, this means the method would be O(n2)
Also if you delete an element you should decrement i by one so that you don't end up skipping any duplicates.
| def longest_prefix(strings) | ||
| raise NotImplementedError, "Not implemented yet" | ||
|
|
||
| common_word = "" |
There was a problem hiding this comment.
You are going to need 2 loops here one of which is looping through the characters inside one of the strings. You only have one loop here and you're comparing using an index for the array as an index for a letter in a word.
2 participants
Both my methods need work to pass...this is what I have so far.