Leaves-Yasmin #41
Open
Leaves-Yasmin #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 19, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Both of these work, but see my notes on the time complexity. Overall nice work!
| index_1 = 0 | ||
| array.times do | ||
| if list[index_1] == list[index_1 + 1] | ||
| list.delete_at(index_1) |
There was a problem hiding this comment.
Actually delete_at will remove the element at index_1 by shifting all the subsequent elements left by one index. So it's an O(n) method. Since you have it nested in a loop running n times. This is actually an O(n2) method.
|
|
||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: o(n^2) |
There was a problem hiding this comment.
This is actually O(mn) where m is the length of the strings and n is the number of strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.