Leaves - Bri #31
Open
Leaves - Bri #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 19, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
The first method does successfully count the number of unique elements in a sorted list. The second, well it looks like you haven't finished it yet.
I'd adjusted the 1st method requirements, but I see how you got the solution you arrived it.
Overall not bad. Take a look at my comments and let me know what questions you have.
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def remove_duplicates(list) |
There was a problem hiding this comment.
I think you should have run the tests here.
| raise NotImplementedError, "Not implemented yet" | ||
| prefix_string = "" | ||
| strings.first.length.times do |index| | ||
| string.each do |string| |
| # Space Complexity: ? | ||
| # Did not have time to complete all the way | ||
|
|
||
| # Time Complexity: O(n^2) |
There was a problem hiding this comment.
Given what you have here I would say O(m * n) where m is the length of the 1st string and n is the number of strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.