Branches - Brianna K #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 19, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Not bad. See my notes on remove_duplicates, as it has troubles. Take a look at my comments and let me know if I can clarify things further.
| # Space Complexity: O(1) | ||
| def remove_duplicates(list) | ||
| raise NotImplementedError, "Not implemented yet" | ||
| (list.length - 1).times do |count| |
There was a problem hiding this comment.
This will miss the times when the number appears 3 times in a row
For example:
[1, 2, 2, 3, 4]
| end | ||
| end | ||
|
|
||
| (list.length - 1).times do |number| |
There was a problem hiding this comment.
I like how this shifts nil to the right. However it misses the problem listed above.
I went ahead and added a test for C13 on this.
|
|
||
| strings.each do |word| | ||
| match = '' | ||
| initial_match.length.times do |letter| |
There was a problem hiding this comment.
These two loops seem to do the roughly same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.