wave 2 finished #28
Open
wave 2 finished #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 19, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
There are some issues here. Check out my comments on the 1st method (remove duplicates). There are circumstances it won't work.
It looks like you're still working through the second method.
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| require "pry" | ||
| # Time Complexity: O(n2) because it is a nested loop. Each loop runs n number of times where n is the |
| c = 0 | ||
|
|
||
| while list[c] != nil | ||
| while list[c] == list[i] |
There was a problem hiding this comment.
This is a little odd and I think you could have i go beyond the bounds of the array. Something could break here.
|
Oh and in the future can you put your 1st name in the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.