fix(deps): reduce npm vulnerabilities via overrides#771
Merged
ErikBjare merged 1 commit intoActivityWatch:masterfrom Feb 27, 2026
Merged
fix(deps): reduce npm vulnerabilities via overrides#771ErikBjare merged 1 commit intoActivityWatch:masterfrom
ErikBjare merged 1 commit intoActivityWatch:masterfrom
Conversation
Add npm overrides for transitive dependencies with known vulnerabilities: - minimatch: override editorconfig's minimatch@9.0.1 to ^9.0.7 (ReDoS fix) - minimatch: override filelist's minimatch to ^5.1.8 (ReDoS fix) - webpack-dev-server: override to ^5.2.1 (source code theft fix) This reduces vulnerabilities from 37 to 32 (14% reduction). The remaining 32 are all rooted in the Vue 2 ecosystem (vue, vue-template-compiler, postcss, d3-color via vue-d3-sunburst, cross-spawn via yorkie, html-minifier via html-loader) and cannot be resolved without a Vue 3 migration. Build and all 34 tests verified passing. Refs: ActivityWatch#581
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 0eb70c6 in 7 seconds. Click for details.
- Reviewed
19lines of code in1files - Skipped
1files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_PPOyVmH8BEjdccrX
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #771 +/- ##
=======================================
Coverage 25.71% 25.71%
=======================================
Files 30 30
Lines 1750 1750
Branches 320 307 -13
=======================================
Hits 450 450
- Misses 1234 1278 +44
+ Partials 66 22 -44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Greptile SummaryThis PR adds npm dependency overrides to address security vulnerabilities in transitive dependencies, reducing the total count from 37 to 32 (a 14% reduction). Changes made:
Key points:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 0eb70c6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Added npm overrides for:
9.0.1→^9.0.7— fixes ReDoS (GHSA-3ppc-4f35-3m26, GHSA-7r86-cg39-jmmj, GHSA-23c5-xmqv-rm74)5.x→^5.1.8— fixes ReDoS4.x→^5.2.1— fixes source code theft vulnerabilities (GHSA-9jgg-88mc-972h, GHSA-4v9v-hfq4-rm2v)Remaining vulnerabilities (Vue 2 ecosystem)
These 32 vulnerabilities all trace back to Vue 2 (EOL) and its ecosystem:
vue@2.7.16— ReDoS in parseHTMLvue-template-compiler— XSS vulnerabilitypostcss— via@vue/component-compiler-utilsd3-color— viavue-d3-sunburst(no fix available)cross-spawn— viayorkie(unmaintained git hook manager)html-minifier— viahtml-loader@0.5.5These can only be resolved as part of a Vue 3 migration.
Follows up on #762 which fixed qs and babel vulnerabilities.
Refs: #581
Test plan
npm run build— passesnpm test— 34 tests pass, 9 suitesnpm audit— 32 vulnerabilities (down from 37)Important
Add npm overrides in
package.jsonto reduce vulnerabilities from 37 to 32, with remaining issues tied to Vue 2 ecosystem.package.jsonforminimatchineditorconfigandfilelist, andwebpack-dev-server.qsandbabelvulnerabilities.This description was created by
for 0eb70c6. You can customize this summary. It will automatically update as commits are pushed.