fix(ci): handle missing server log files in cleanup steps

[TimeToBuildBob]

Summary

• Fixes false CI failures on the aw-server-rust master test matrix entry
• When the server writes logs to stdout/stderr instead of files, the glob ~/.cache/activitywatch/log/*/*.log has no matches, causing bash to treat it as a literal string → cat/mv fails → step fails → job shows as red

Fix

• Use shopt -s nullglob so unmatched globs expand to nothing
• Switch mv glob to a for-loop that handles the empty case gracefully

Context

Re-submission of #768 which was mistakenly closed — #767 (date range picker fix) was merged but is unrelated to this CI issue. The log cleanup failure still occurs on every PR's aw-server-rust master matrix entry.

---

Important

Fixes CI false failures by handling missing log files with shopt -s nullglob and a for-loop in nodejs.yml.

• CI Fix:
  • Use shopt -s nullglob in nodejs.yml to handle unmatched globs, preventing false CI failures.
  • Replace mv command with a for-loop to handle empty log file cases gracefully.
• Context:
  • Addresses log cleanup failure in aw-server-rust master test matrix entry.
  • Re-submission of fix(ci): handle missing server log files in cleanup steps #768, unrelated to fix: allow single-date selection in timeline date range picker #767.

^{This description was created by for ccc77c4. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to ccc77c4 in 5 seconds. Click for details.

• Reviewed 26 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 0 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_IdHOhFLWNdIo4mzL

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[greptile-apps]

Greptile Summary

This PR fixes false CI failures in the aw-server-rust master test matrix entry. When the server writes logs to stdout/stderr instead of files, the glob pattern ~/.cache/activitywatch/log/*/*.log has no matches, causing bash to treat it as a literal string and making cat and mv commands fail.

The fix applies two changes:

• Adds shopt -s nullglob so unmatched globs expand to nothing instead of literal strings
• Replaces the mv glob command with a for-loop that gracefully handles the empty case

Both the "Print server logs to console" and "Move logs to subdir" steps are now properly protected against missing log files. The changes are minimal, targeted, and preserve the existing behavior when log files do exist.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The fix is a straightforward bash scripting improvement that addresses a specific CI failure scenario. The changes use standard bash best practices (shopt -s nullglob and for-loops) to handle missing files gracefully. Both modified steps are cleanup/logging operations with if: ${{ always() }} guards, so they don't affect the core test logic. The fix has no impact on the actual application code.
• No files require special attention

Important Files Changed

Filename	Overview
.github/workflows/nodejs.yml	Adds nullglob handling and for-loop to prevent CI failures when log files are missing

_{Last reviewed commit: ccc77c4}

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.60%. Comparing base (1393ec6) to head (ccc77c4).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #769   +/-   ##
=======================================
  Coverage   25.60%   25.60%           
=======================================
  Files          30       30           
  Lines        1746     1746           
  Branches      306      306           
=======================================
  Hits          447      447           
  Misses       1277     1277           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ErikBjare]

I'm pretty sure the root cause was ActivityWatch/aw-server-rust#565 which was merged?

We just need another commit to master/rerun CI to address/verify this, or?

[ErikBjare]

Actually, master seems to be passing?

[TimeToBuildBob]

Right, aw-server-rust#565 fixed the root cause (server now writes log files to the expected location). If master CI is passing now, this PR is just a defensive fix — handles the edge case where log files are missing for any reason so the cleanup step doesn't fail.

Happy to close this if you think it's unnecessary now, or merge it as a robustness improvement. Your call!

[ErikBjare]

Closing, we should fail on the empty case as it suggests logs weren't being written or picked up.