fix(timeline): truncate long synced bucket names in sidebar#757
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to c1c2d34 in 6 seconds. Click for details.
- Reviewed
54lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_u9jACVncNvfXTTdb
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Greptile SummaryFixes long synced bucket names causing sidebar overflow by abbreviating them from
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: c81046c |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #757 +/- ##
=======================================
Coverage 25.60% 25.60%
=======================================
Files 30 30
Lines 1746 1746
Branches 319 319
=======================================
Hits 447 447
Misses 1233 1233
Partials 66 66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Greptile Review Addressed — XSS FixThanks for the security catch! Fixed in b0b62fe:
All three comment threads addressed. |
…Watch#682) Synced bucket names can exceed 137+ characters, making the timeline sidebar unusable on smaller screens. Three fixes: - CSS text-overflow ellipsis as fallback for any long label - Abbreviate synced names: show 'watcher-name (synced from host)' instead of full 'watcher_localhost-synced-from-remotehost' - Add title tooltip showing full bucket ID on hover - Fix: use group.id instead of group.content when looking up bucket ID for event editing (content now contains display HTML, not raw ID)
b0b62fe to
c81046c
Compare
|
@greptileai review |
Summary
Fixes #682 — synced bucket names can exceed 137+ characters (e.g.
aw-watcher-window_longhost-synced-from-longhost), making the timeline sidebar unusable on smaller screens.Changes
Smart abbreviation for synced bucket names:
aw-watcher-window_host-synced-from-remotehost→aw-watcher-window (synced from remotehost)synced-fromboilerplateCSS safety net for any long label:
max-width: 250pxwithtext-overflow: ellipsison the vis-timeline label sidebarBug fix:
onSelectusedgroup.content(display HTML) instead ofgroup.id(bucket ID) when looking up the bucket for event editing. Previously worked by coincidence sincecontentequaledbucket.id, but would break with any label abbreviation.Before/After
Before (from issue #682):
Takes up most of the screen width in the sidebar.
After:
Compact label with full ID on hover.
Important
Abbreviates long synced bucket names in the timeline sidebar and fixes a bucket lookup bug in
VisTimeline.vue.abbreviateBucketName()inVisTimeline.vueto prevent sidebar overflow.onSelect()inVisTimeline.vueby usinggroup.idinstead ofgroup.contentfor bucket lookup.max-width: 250pxandtext-overflow: ellipsisto.vis-labelset .vis-label .vis-innerinVisTimeline.vueto handle long labels.This description was created by
for c1c2d34. You can customize this summary. It will automatically update as commits are pushed.