removed audio_features request (deprecated)#35
Merged
ErikBjare merged 2 commits intoActivityWatch:masterfrom Sep 8, 2025
Merged
removed audio_features request (deprecated)#35ErikBjare merged 2 commits intoActivityWatch:masterfrom
ErikBjare merged 2 commits intoActivityWatch:masterfrom
Conversation
When requesting audio_features the watcher doesn't run at all since the feature was removed from the Spotify API entirely. Removing the request makes it run again just fine, it seems the feature was only used to request ``"id"`` specifically. See: https://developer.spotify.com/documentation/web-api/reference/get-audio-features
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 5eeb828 in 1 minute and 14 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. aw_watcher_spotify/main.py:40
- Draft comment:
There's a minor spacing issue on this line. It might be clearer to have a space after theelsekeyword (i.e.,else {}instead ofelse{}), which improves readability. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the comment is technically correct about Python style conventions, this is an extremely minor formatting issue. Such minor style issues are typically better handled by automated formatters like black or pylint. The comment doesn't point out any functional issues or suggest meaningful improvements to the code quality. The spacing issue could potentially affect code readability. Some might argue that consistent formatting is important for maintainability. While consistent formatting is important, this is too minor to warrant a PR comment. This kind of feedback should be handled by automated tools rather than manual review comments. Delete this comment as it addresses an extremely minor formatting issue that would be better handled by automated formatting tools.
Workflow ID: wflow_zDnzHCgkI7Dh2vGp
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Member
|
Thanks @evopls! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When requesting audio_features the watcher doesn't run at all since the feature was removed from the Spotify API entirely.
Removing the request makes it run again just fine, it seems the feature was only used to request
"id"specifically.See: https://developer.spotify.com/documentation/web-api/reference/get-audio-features
Important
Removes deprecated
audio_featuresAPI call indata_from_track()to ensure watcher runs without errors.sp.audio_features(track["item"]["id"])indata_from_track()inmain.py.audio_features.This description was created by
for 5eeb828. You can customize this summary. It will automatically update as commits are pushed.