feat:accept --port argument for custom ports#36
Open
0xbrayo wants to merge 1 commit intoActivityWatch:masterfrom
Open
feat:accept --port argument for custom ports#360xbrayo wants to merge 1 commit intoActivityWatch:masterfrom
0xbrayo wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 3ae4047 in 49 seconds. Click for details.
- Reviewed
18lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/aw_watcher_input/main.py:15
- Draft comment:
Consider validating the port number within the valid range (e.g. 1-65535) using click.IntRange to avoid misconfigured ports. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. src/aw_watcher_input/main.py:19
- Draft comment:
Ensure ActivityWatchClient supports the new 'port' parameter and properly handles invalid values. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_bUEn3Cli3XIBIWKN
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add
--portoption tomain()inmain.pyfor customaw-serverport connection, defaulting to 5600.--portoption tomain()inmain.pyto specify custom port foraw-serverconnection.ActivityWatchClientconstructor.main()function signature to includeportparameter.This description was created by
for 3ae4047. You can customize this summary. It will automatically update as commits are pushed.