feat: add toml config and arg parsing for poll time#33
Open
Joeyrsp wants to merge 1 commit intoActivityWatch:masterfrom
Open
feat: add toml config and arg parsing for poll time#33Joeyrsp wants to merge 1 commit intoActivityWatch:masterfrom
Joeyrsp wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
0xbrayo
reviewed
Jun 30, 2024
ErikBjare
reviewed
Jul 1, 2024
Comment on lines
-12
to
+11
|
|
||
| @click.command() | ||
| @click.option("--testing", is_flag=True) | ||
| def main(testing: bool): | ||
| def main(args, testing: bool): |
Member
There was a problem hiding this comment.
Please don't remove click. Rewrite to use it instead.
@ellipsis-dev try to do this for us.
Edit: Ellipsis won't, but should be trivial to get ChatGPT etc to rewrite this if you're not familiar.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Author
There was a problem hiding this comment.
no worries. wasnt sure what was the new and what was the old
This comment was marked as resolved.
This comment was marked as resolved.
ellipsis-dev bot
added a commit
that referenced
this pull request
Jul 1, 2024
… arg parsing for poll time);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when aw-watcher-input got bundled i switched to the bundled version forgetting that i had been running a modified local version with an increased poll time. it would be great to use a toml config file like with the rest of the watchers so i just yoinked code from aw-watcher-afk and jammed it in here.
happy to make any changes like default config or to fit code style but i figure its probably pretty close since its 90% your code anyway