build(deps): pynput needs python 3.13#72
Open
Game4Move78 wants to merge 1 commit intoActivityWatch:masterfrom
Open
build(deps): pynput needs python 3.13#72Game4Move78 wants to merge 1 commit intoActivityWatch:masterfrom
Game4Move78 wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 1f5ac1f in 21 seconds
More details
- Looked at
14lines of code in1files - Skipped
1files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. pyproject.toml:13
- Draft comment:
The version constraint '^3.8,<3.13' correctly prevents Python 3.13 usage due to pynput issues. Ensure to update this once the upstream fix is merged. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is purely informative, explaining the reason behind a version constraint. It doesn't provide a specific code suggestion or ask for a test to be written. It also doesn't ask for confirmation of intention or any other action from the PR author.
2. pyproject.toml:13
- Draft comment:
Restricting Python version to <3.13 is a good temporary workaround for the pynput issue. Consider adding a note linking the expected fix branch (e.g., fixup/listener-thread-handle) so it's easier to revert this when the issue is resolved. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_4wCZaK646s5X0HVY
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal changes to the Python threading library in 3.13 breaks pynput. Likely to be fixed when fixup/listener-thread-handle is merged, but at the moment Python 3.13 will throw this error:
Related to activitywatch#1122, pynput#614
Important
Update Python version constraint in
pyproject.tomlto exclude 3.13 due topynputcompatibility issue.pyproject.tomlto^3.8,<3.13due topynputcompatibility issue with Python 3.13.This description was created by
for 1f5ac1f. It will automatically update as commits are pushed.