feat: replace aw-notify (Python) with aw-notify-rs (Rust)#1210
Closed
TimeToBuildBob wants to merge 1 commit intoActivityWatch:masterfrom
Closed
feat: replace aw-notify (Python) with aw-notify-rs (Rust)#1210TimeToBuildBob wants to merge 1 commit intoActivityWatch:masterfrom
TimeToBuildBob wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
Replaces the aw-notify Python submodule (ErikBjare/aw-notify) with aw-notify-rs (0xbrayo/aw-notify-rs), a Rust reimplementation that provides the same notification features with better performance and native compilation. Changes: - Remove aw-notify submodule (Python/poetry-based build) - Add aw-notify-rs submodule (Rust/cargo-based build) - Update Makefile to use aw-notify-rs in SUBMODULES - Update CI workflows to reference aw-notify-rs - Add aw-notify-rs/target to cargo cache in both CI workflows The aw-notify-rs submodule already provides compatible Makefile targets (build, package, clean) that integrate cleanly with the existing activitywatch build system. Requested by @0xbrayo.
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 732ad11 in 6 seconds. Click for details.
- Reviewed
93lines of code in6files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_4YXq9sQ2qJ7ZkEaq
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
4 tasks
Greptile SummaryReplaced Python-based Key Changes:
Integration Notes:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 732ad11 |
Member
|
This is superseded by #1211, feel free to add any changes there. @TimeToBuildBob |
Member
|
Seems to failing due to notarization, either could work! |
Contributor
Author
|
Closing in favor of #1211 — 0xbrayo's version supersedes this one. Will contribute any remaining changes there if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
aw-notifyPython submodule (ErikBjare/aw-notify) withaw-notify-rs(0xbrayo/aw-notify-rs), a Rust reimplementation that provides identical notification behavior with better performance and native compilation.Requested by @0xbrayo.
Changes
aw-notifysubmodule (ErikBjare/aw-notify, Python/poetry-based)aw-notify-rssubmodule (0xbrayo/aw-notify-rs, Rust/cargo-based)aw-notifywithaw-notify-rsinSUBMODULESaw-notify-rsin bothbuild.ymlandbuild-tauri.ymlaw-notify-rs/targetto the cargo build cache in both workflowsBuild Process Differences
poetry install+pyinstallercargo build --releasebuild,package,cleanbuild,package,clean(compatible ✅)dist/aw-notify/(PyInstaller bundle)dist/aw-notify(single native binary)The
aw-notify-rsMakefile already provides compatiblebuild,package, andcleantargets, so the activitywatch build system integrates without changes to the main build logic.Testing
The CI will validate the Rust build. The
aw-notify-rsbinary:localhost:5600by defaultImportant
Replace Python
aw-notifywith Rustaw-notify-rsfor improved performance and native compilation.aw-notifysubmodule.aw-notify-rssubmodule.aw-notifywithaw-notify-rsinSUBMODULES.build.ymlandbuild-tauri.ymlto referenceaw-notify-rs.aw-notify-rs/targetto cache paths in both workflows.This description was created by
for 732ad11. You can customize this summary. It will automatically update as commits are pushed.