Open
Conversation
|
|
||
| function getTooltip(key: string) { | ||
| return tooltips[key]; | ||
| return ":" + tooltips[key]; |
There was a problem hiding this comment.
🐛 Bug
The getTooltip function does not check if the key exists in the tooltips object before accessing it. This could lead to returning ':undefined' if the key is not found, potentially causing unexpected behavior when the tooltip is used.
Suggested change
| return ":" + tooltips[key]; | |
| return tooltips[key] ? ':' + tooltips[key] : undefined; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨
Description by Cal
This PR updates the
getTooltipfunction to prepend a colon to the tooltip string returned from thetooltipsobject.Diagrams of code changes
sequenceDiagram participant User participant getTooltip participant tooltips User->>getTooltip: Call with key getTooltip->>tooltips: Access tooltip for key tooltips-->>getTooltip: Return tooltip value getTooltip-->>User: Return ":" + tooltip valueKey Issues
Files Changed
File: /helpers/shortcuts.ts
Updated the `getTooltip` function to prepend a colon to the returned tooltip string.