fix: handle undefined pathname in URL builder#2021
fix: handle undefined pathname in URL builder#2021UnschooledGamer wants to merge 4 commits intoAcode-Foundation:mainfrom
Conversation
Return early when pathname is undefined to avoid inserting an extra ':' and strip a leading '/' from newDocId before concatenation
|
Oh no, biome didn't complain locally. We'll be fixed before merging |
Greptile SummaryThis PR adds an early-return path in Confidence Score: 4/5Safe to merge; the fix produces correct URLs for the targeted edge case. The only remaining finding (P2) is that the two separator branches inside src/utils/Url.js — the
|
| Filename | Overview |
|---|---|
| src/utils/Url.js | Adds early return for Termux URLs when pathname is undefined; separator branches inside if(!pathname) are dead code due to prior rootCondition/newDocIdCondition processing, but the overall path result is correct. |
Reviews (3): Last reviewed commit: "Update Url.js" | Re-trigger Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
@greptileai review again |
Return early when pathname is undefined to avoid inserting an extra ':' and strip a leading '/' from newDocId before concatenation