Conversation
|
Hi @aemonge! Thanks for the PR, I'm planning to look into this in more detail soon. Would you in the meantime remove all the formatting changes which distracts from the actual changes. I should probably add a |
|
Is this better? |
|
Yes, thanks! Would you also mind adding |
|
:) Done |
|
Btw, not sure why CI is failing, need to look into that, seems unrelated to this PR |
|
Please let me know if it's related to the PR, and I'll work on it :) It feels good to participate in the repo. |
|
If you rebase on |
|
Hey @AckslD there were too many conflicts for a rebase, I hope a merge is ok with you. |
|
I've also added support for |
|
Thanks for noticing this @neolooong |
|
@AckslD Code was broken, now it should work 😉 |
No description provided.