Add custom loot table for missing pickup loot#53
Add custom loot table for missing pickup loot#53Mathys-Rituper wants to merge 1 commit intoAccieo:mainfrom
Conversation
|
Btw : as of right now, I did not put a ton of time into balancing the odds for this new loot table. Since it is an opinionated decision to make, this is left to the mod's maintainer |
| } | ||
|
|
||
| val selectedId = lootTables.random() | ||
| Cobbleworkers.LOGGER.info("[PickUpLooter] Selected loot table: $selectedId at $origin") |
There was a problem hiding this comment.
Unfortunately, this will pollute server logs quite a lot, especially servers with quite a few players that are using pick up farms.
| if (drops.isNotEmpty()) { | ||
| lastGenerationTime[pokemonId] = now | ||
| heldItemsByPokemon[pokemonId] = drops | ||
| Cobbleworkers.LOGGER.info("[PickUpLooter] Generated ${drops.size} items: ${drops.joinToString { "${it.item}" }}") |
There was a problem hiding this comment.
Same here, this will pollute server logs.
There was a problem hiding this comment.
This looks good, but ideally we should also add a chance to each one, otherwise it will be guaranteed that a single item from each pool is generated every single time, which is quite unbalanced.
It should follow the same approach as the archaeology treasure loot table.
Accieo
left a comment
Accieo
left a comment
There was a problem hiding this comment.
are you okay with implementing the stuff mentioned in the comments? If not, I can take over, I will leave it up to you.
whatever the decision, thanks a lot for the contribution!
2 participants
Pickup Treasure Loot Table
Overview
This custom loot table (
cobbleworkers:pickup_treasure) provides Pokémon with the Pickup ability a themed set of items that mimics the Pickup ability from the mainline Pokémon games, since the default loot tables imported from Cobblemon are missing some items.Loot table contents
Cobblemon Items Only - Only includes items from the Cobblemon mod, no vanilla Minecraft items
No Duplicates - Items in this loot table do not appear in other Cobbleworkers loot tables (dive_treasure, archeology_treasure) or Cobblemon's built-in loot tables
Thematic Relevance - Items are chosen based on Pokemon Scarlet/Violet pickup table
Integration with PickUpLooter Job
The
PickUpLooterjob uses this loot table alongside Cobblemon's built-in loot tables:**cobbleworkers:pickup_treasure**(NEW)cobblemon:sets/any_ancient_held_itemcobblemon:sets/any_common_pokeballcobblemon:sets/any_evo_stonecobblemon:sets/any_exp_candycobblemon:sets/any_natural_heal_itemcobblemon:sets/any_type_gemcobblemon:sets/any_apricorn_seedcobblemon:villages/village_pokecentersThis ensures a good variety of items while avoiding duplicates.
Dev convenience
Also added a few extra logging statements to better debug Pickup in the future