feat: EXR performance, hotkey editor, viewport fixes#229
Open
throb wants to merge 4 commits intoAcademySoftwareFoundation:mainfrom
Open
feat: EXR performance, hotkey editor, viewport fixes#229throb wants to merge 4 commits intoAcademySoftwareFoundation:mainfrom
throb wants to merge 4 commits intoAcademySoftwareFoundation:mainfrom
Conversation
…e loading
Three issues prevented image sequences (EXR, etc.) from loading on Windows:
1. Broken backslash regex in scan_posix_path() - the character class [\]
matched ']' instead of '\', leaving backslashes in scanned file paths.
2. pad_size() returned 0 for non-zero-padded frame numbers (e.g. "1000"),
producing invalid %00d / {:00d} format specifiers that failed extension
matching in is_file_supported().
3. posix_path_to_uri() did not normalise backslashes to forward slashes on
Windows, leaking them into file: URIs.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add --review / -v CLI flag to launch xstudio in "Present" layout (viewport only, no playlists or timeline). This overrides saved user layout preferences on startup. Also add drag-drop handling to the viewport panel so files can be dropped directly onto the viewer in any layout. Previously drops were only handled by the media list panel, which doesn't exist in the Present layout. Bump version to 1.1.1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove Gamma and Saturation from the default hidden toolbar items so they are visible by default in the viewport toolbar. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
EXR Performance: - Dispatch up to 4 concurrent precache requests in do_precache() - Add configurable EXR decompression thread count preference (default 16) - Fix off-by-one in EXR resolution reporting (max-min → max-min+1) - Crop data window to display window by default (0% overscan) - Add standalone EXR benchmark tool Hotkey Editor: - Replace read-only hotkey viewer with full interactive editor - Click-to-capture key rebinding with conflict detection and warnings - Persistent hotkey overrides saved to %LOCALAPPDATA%/xstudio/ - Search filtering, per-key and reset-all functionality - Scrollbar for overflow content Viewport Fixes: - Fix SSBO shader debug colors (red/blue → black) for out-of-bounds pixels - Fix FBO texture wrap mode (GL_CLAMP_TO_EDGE → GL_CLAMP_TO_BORDER) - Fix overscan display: crop EXR data window to display window by default Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed Files (18 files, +1728/-68)
bench/exr_benchmark/— standalone EXR decompression benchmark toolsrc/plugin/media_reader/openexr/— concurrent precache, configurable thread count, overscan fixsrc/media_reader/— frame request queue supports multiple in-flight requestssrc/ui/qml/viewport/src/hotkey_ui.cpp— interactive hotkey editor backendui/qml/xstudio/widgets/dialogs/hotkeys/— hotkey editor QML UI + delegatesrc/ui/opengl/src/shader_program_base.cpp— SSBO debug color fixsrc/ui/qt/viewport_widget/— FBO texture border fixshare/preference/plugin_media_reader_openexr.json— new EXR preferencesTest plan
bench/exr_benchmarkagainst a test EXR sequence🤖 Generated with Claude Code