neon: fix missing had8x8 dispatch and remove AVX dead code#200
Open
kjg0724 wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
neon: fix missing had8x8 dispatch and remove AVX dead code#200kjg0724 wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
kjg0724 wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Connect oapv_dc_removed_had8x8_neon to the encoder NEON dispatch block, which was falling back to the C reference despite the NEON implementation being available. Remove leftover AVX256 macros (CALCU_2x8, CALCU_2x4, CALCU_LINE_1x8 and their variants) from oapv_tq_neon.h. These were copied from the AVX header but never converted to NEON intrinsics and are unused. Also remove a redundant fn_dquant assignment in the decoder NEON block that duplicated the default C reference already set above. Signed-off-by: Jeongkeun Kim <variety0724@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encoder NEON platform init connects fn_itx, fn_txb, and fn_quant
to their NEON implementations but leaves fn_had8x8 on the C reference.
This patch wires it to oapv_dc_removed_had8x8_neon.
Also cleans up AVX256 intrinsic macros (CALCU_2x8, CALCU_2x4,
CALCU_LINE_1x8, etc.) that were left in oapv_tq_neon.h — these are
unused dead code from a copy-paste of the AVX header.
Additionally removes a redundant fn_dquant assignment in the decoder
NEON block that simply duplicated the default already set in the
common initialization path.
Tested on Apple Silicon (M-series):