Merged
Conversation
Expose prodtrack_detail_url on versions, user setting for auto-sync, header PT tab button, extension bridge and install prompt. Signed-off-by: James Spadafora <spadjv@gmail.com> Made-with: Cursor
- Changed default value of `sync_prodtrack_tab_on_version_change` to `True` in `UserSettings` model. - Updated MongoDB storage provider to reflect the new default setting. - Adjusted tests to verify the new default behavior for user settings. - Modified frontend components to ensure they respect the updated sync behavior. This change enhances user experience by ensuring the production tracking tab syncs automatically when version changes occur. Signed-off-by: James Spadafora <spadjv@gmail.com>
Signed-off-by: James Spadafora <spadjv@gmail.com>
- Introduced functions to handle split view IDs for tabs, allowing controlled tabs to attach to anchor tabs in a split view. - Updated the `openOrUpdateControlledTab` function to attempt attaching to the anchor tab's split view when opening or updating a controlled tab. - Enhanced error handling to ensure robustness when interacting with Chrome's tab API. This change improves the user experience by maintaining tab organization in split view scenarios. Signed-off-by: James Spadafora <spadjv@gmail.com>
…n functionality - Updated the ProdtrackTabSyncInstallDialog to include additional instructions for configuring the Chrome extension when served over HTTP on non-localhost origins. - Simplified the SettingsModal description regarding the Chrome extension requirement. - Improved the prodtrack-tab-sync-extension to handle tab synchronization more effectively, including new functions for managing tab origins and split views. - Updated the extension manifest to allow external messaging from all origins and clarified the README regarding external message handling. These changes improve user guidance and enhance the functionality of the tab synchronization feature. Signed-off-by: James Spadafora <spadjv@gmail.com>
Signed-off-by: James Spadafora <spadjv@gmail.com>
- Removed the ProdtrackTabSyncInstallDialog component as it is no longer needed. - Updated the ContentArea component to streamline the handling of production tracking tab synchronization, including the use of a new function to open URLs in a new tab if the extension is not available. - Enhanced the VersionHeader component to conditionally render the production tracking tab button based on the availability of the extension. - Improved tests to reflect changes in the production tracking tab sync logic. These updates simplify the user experience and improve the functionality of the production tracking feature. Signed-off-by: James Spadafora <spadjv@gmail.com>
Signed-off-by: James Spadafora <spadjv@gmail.com>
…emySoftwareFoundation/dna into cursor/prodtrack-tab-sync-issue-136 Signed-off-by: James Spadafora <spadjv@gmail.com>
Signed-off-by: James Spadafora <spadjv@gmail.com> Made-with: Cursor
jspada200
force-pushed
the
cursor/prodtrack-tab-sync-issue-136
branch
from
b30bc9f to
70979cf
Compare
Signed-off-by: James Spadafora <spadjv@gmail.com> Made-with: Cursor
Signed-off-by: James Spadafora <spadjv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds an extension that gives DNA control over the browser. The advantage with this is that we can update a tab to match what we are looking at in DNA. This solves the issue of the info surface being missing from DNA. TODO: We will need to put the extension of the google extension store to make it easy for cords to access and install.
Testing
How I Tested
Used locally.
Resolved #136