Refactor wrapper from tsh to sh#788
Closed
cedrik-fuoco-adsk wants to merge 10 commits intoAcademySoftwareFoundation:mainfrom
Closed
Refactor wrapper from tsh to sh#788cedrik-fuoco-adsk wants to merge 10 commits intoAcademySoftwareFoundation:mainfrom
cedrik-fuoco-adsk wants to merge 10 commits intoAcademySoftwareFoundation:mainfrom
Conversation
This reverts commit fa0833c.
revert changes Signed-off-by: pbergeron-adsk <patrick.bergeron@autodesk.com>
Revert changes Signed-off-by: pbergeron-adsk <patrick.bergeron@autodesk.com>
removed last line diff Signed-off-by: pbergeron-adsk <patrick.bergeron@autodesk.com>
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor wrapper from tsh to sh
Linked issues
Discussion #90
Summarize your change.
Refactoring the wrapper from tsh to sh.
Describe the reason for the change.
shis available on virtually all Unix-like systems whiletshis not. Also, this is a takeover the PR #384 since the author does not have bandwidths to work on this.Describe what you have tested and on which operating system.
Linux
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.