feat: add fps options 60 5994 to Control FPS menu#1184
Open
mcoliver wants to merge 6 commits intoAcademySoftwareFoundation:mainfrom
Open
feat: add fps options 60 5994 to Control FPS menu#1184mcoliver wants to merge 6 commits intoAcademySoftwareFoundation:mainfrom
mcoliver wants to merge 6 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Michael Oliver <mcoliver@gmail.com>
Signed-off-by: Michael Oliver <mcoliver@gmail.com>
Signed-off-by: Michael Oliver <mcoliver@gmail.com>
…gnoring this file caused me some strife when trying to update menu's as my initial grep failed to find the strings I was looking for Signed-off-by: Michael Oliver <mcoliver@gmail.com>
mcoliver
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #911
Also updated .gitignore to not ignore the rvui.mu file. There was reference to a rvui.mu.in file existing but I don't see it anywhere in the repo, git log, or github and having it ignored messes with git, grep, and other utilities that reference that file. Made it a bit more difficult than necessary to find where to make the changes.
Linked issues
Summarize your change.
Describe the reason for the change.
Describe what you have tested and on which operating system.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.