[cuegui/cuebot] Fix UI freeze on gRPC connection drops and add job unavailable notification#2143
Merged
ramonfigueiredo merged 9 commits intoAcademySoftwareFoundation:masterfrom Jan 17, 2026
Conversation
…le notification - Add null checks in AbstractGraphWidget.handleSelectObjects() to prevent AttributeError when selecting nodes that no longer exist in the graph - Add gRPC error handling in LayerMonitorTree._getUpdate() for NOT_FOUND, INTERNAL, CANCELLED, and UNAVAILABLE status codes - Add gRPC error handling in JobMonitorGraph.createGraph(), update(), and setupNodeConnections() methods with proper null checks - Add gRPC error handling in FrameMonitorTree._getUpdate() and _getUpdateChanged() for job not found scenarios - Add job_not_found signal to CueGuiApplication for cross-widget communication - Add popup notification in JobMonitorTree when a job has been moved to historical data and is no longer accessible - Auto-remove unavailable jobs from the monitor list
ramonfigueiredo
force-pushed
the
fix/cuegui-grpc-connection-drop-handling
branch
from
eebeac8 to
7fcf764
Compare
ramonfigueiredo
requested review from
DiegoTavares and
lithorus
as code owners
Collaborator
Author
|
@DiegoTavares / @lithorus |
DiegoTavares
requested changes
Jan 12, 2026
… errors Update INTERNAL error handling to check for "Failed to find job data" message before treating it as a job-not-found scenario. Other INTERNAL errors are now logged without incorrectly triggering job unavailable notifications.
ramonfigueiredo
force-pushed
the
fix/cuegui-grpc-connection-drop-handling
branch
from
697bc6b to
721262f
Compare
ramonfigueiredo
changed the title
…data Cuebot: - Update ManageJob.java to return NOT_FOUND status code instead of INTERNAL when job data is not found in the database CueGui: - Simplify gRPC error handling by removing INTERNAL error checks for job-not-found scenarios since server now returns NOT_FOUND - Files updated: FrameMonitorTree.py, LayerMonitorTree.py, JobMonitorGraph.py
ramonfigueiredo
force-pushed
the
fix/cuegui-grpc-connection-drop-handling
branch
from
2979df2 to
0e6b1ae
Compare
Group multiple job unavailable notifications that occur within 500ms into a single message box instead of showing separate popups for each job. This improves UX when multiple monitored jobs expire simultaneously.
Collaborator
Author
|
Ready for review again |
DiegoTavares
approved these changes
Jan 17, 2026
Skip adding jobs in addJob() if they are in the __notifiedJobsNotFound were just removed because they are no longer available (moved to historical data).
Add check in _processUpdate to skip jobs that are in __notifiedJobsNotFound set when iterating over rpcObjects. This complements the addJob fix and ensures jobs removed due to NOT_FOUND errors are not re-added during the update cycle.
- Add finished jobs to monitored_proxies in _getUpdate() so they are verified against the server during background updates - Emit job_not_found signal for finished jobs that no longer exist, enabling batch detection of multiple archived jobs at once - Skip jobs in __notifiedJobsNotFound set in both addJob() and _processUpdate() to prevent re-adding jobs after removal - This ensures the batch notification popup works correctly when multiple monitored jobs are archived simultaneously
- Verify finished jobs still exist during background updates by adding them to monitored_proxies in _getUpdate() - Emit job_not_found signal for finished jobs that are no longer found, enabling automatic detection of archived jobs - Skip jobs in __notifiedJobsNotFound set in addJob() and _processUpdate() to prevent re-adding jobs after they are removed - Use custom scrollable dialog for multiple job notifications instead of QMessageBox, ensuring the dialog remains usable with hundreds of jobs - Sort job names in the dialog for easier reading
Collaborator
Author
|
ramonfigueiredo
merged commit c4b0cac
into
AcademySoftwareFoundation:master
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Summarize your change.
Cuebot:
when job data is not found in the database
CueGUI: