Add CI coverage for Slang shader validation #2982
Open
krishnamanchikalapudi wants to merge 2 commits into
Open
Add CI coverage for Slang shader validation #2982krishnamanchikalapudi wants to merge 2 commits into
krishnamanchikalapudi wants to merge 2 commits into
Conversation
Slang shaders were generated in CI (--target slang) but never compiled, unlike GLSL (Windows) and MSL (macOS) which run a real validator. Add a Slang validation step that downloads the prebuilt slangc release and runs generateshader.py with slangc as the --validator, gated behind a new test_slang matrix flag on a Linux runner. Also update generateshader.py docs to list all currently supported targets (incl. Slang). Refs: AcademySoftwareFoundation#2668 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jstone-lucasfilm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/main.yml):test_slang: ONmatrix flag on the Linux GCC 14 Python 3.13 job.Shader Validation Tests (Slang)build step that downloads the prebuiltslangccompiler release (v2026.10.2) and runs validation tests on standard surface examples and the stdlib test suite usinggenerateshader.py.python/Scripts/generateshader.py):--targethelp text to list Slang, ESSL, Vulkan, and WGSL as supported target generators.Verification Plan
slangcto validate generated Slang files.reference