UsdPreviewSurface opacityMode string input#2955
Open
ld-kerley wants to merge 2 commits into
Open
Conversation
…patibility. Added unit tests for both modes. Updated validation logic to allow for mis-matched types if enumeration is present
ld-kerley
force-pushed
the
usdpreview-opacity-mode-string
branch
from
2e7baf0 to
282ad11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2896
Add version of
ND_UsdPreviewSurface_surfaceshaderwithopacityModeinput as a string for compatibility with OpenUSD version of UsdPreviewSurface.Added unit tests for both modes.
Updated validation logic to allow for mis-matched types if enumeration is present - previously a
NodeGraphimplementation would fail validation if astringinput with anenumattribute was used as its resolvedintegertype.