Add UsdUVTexture v2.3 variant with vector4 scale and bias#2944
Add UsdUVTexture v2.3 variant with vector4 scale and bias#2944ld-kerley wants to merge 3 commits into
Conversation
kwokcb
left a comment
kwokcb
left a comment
There was a problem hiding this comment.
Looks good to me. Maybe add an instance of this variant to the existing usd or image sample test files.so can be used for mtlx and usd testing.
Introduces ND_UsdUVTexture_23_vector4 nodedef and IMP_UsdUVTexture_23_vector4 nodegraph implementation, where the `scale` and `bias` inputs are typed as vector4 instead of the original color4-derived behavior. The prior variant is retained for now and may be removed in a future MaterialX release via an upgrade function.
… the nodedefs with the new version can be selected
ld-kerley
force-pushed
the
usduvtexture-vector4-type-bias-scale
branch
from
fb1c1bc to
b3d765b
Compare
|
added unit test - now we have a test that tests UsdUVTexture and also the new typed scale and bias. |
There was a problem hiding this comment.
Just a couple of small items:
- Both of these and the existing
usd_preview_surface_brass_tiled.mtlxin the same folder use the samesurfacematerialnameUSD_Tiled_Brass. Could you give unique names to these new ones so they can be generate uniquely named output folders + image file names. I think they may overwrite each other. - For efficiency, could you combine them into 1 file as well, then any further variants will only require a single file update.
Thanks.
There was a problem hiding this comment.
Done.
Although I wonder if we can make the test image generation more robust than needing unique names across multiple files?
- use the filename?
- have the test system merge all the unit test files together an validate?
Merging these three files in to one also feels a little more fragile - its much easier to just copy the entire file and modify the material - move these to all be in the same file required more care with node naming etc - easier to get wrong?
2 participants
Resolves #2895
Introduces
ND_UsdUVTexture_23_vector4nodedef and IMP_UsdUVTexture_23_vector4nodegraph implementation, where thescaleandbiasinputs are typed as vector4 instead of the original color4-derived behavior. The prior variant is retained for now for compatibility but could be removed in a future MaterialX release via an upgrade function.