GraphEditor : Fix top level input connection storage and connection logic.#2830
Open
kwokcb wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
GraphEditor : Fix top level input connection storage and connection logic.#2830kwokcb wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
kwokcb wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
- Copies logic from commit: AcademySoftwareFoundation@09f66bb - Fix graph connection setting on input rename.
kwokcb
commented
Mar 18, 2026
Contributor
Author
kwokcb
left a comment
There was a problem hiding this comment.
@lfl-eholthouser , @jstone-lucasfilm. This patches enough logic for this workflow to prevent data loss (no connections) / corruption (incorrect connections) / crashing.
It does not fix other outstanding rendering issues.
| if (!interfaceName.empty()) | ||
| { | ||
| ConstGraphElementPtr graph = getAncestorOfType<GraphElement>(); | ||
| if (graph && graph == getParent()) |
Contributor
Author
There was a problem hiding this comment.
@jstone-lucasfilm . This is the same fix you put in for validation. Would otherwise fail silently leaving Mtlx doc and UiNode graph with different connections.
| } | ||
| } | ||
| // Is a node graph | ||
| else if (uiNode->getNodeGraph()) |
Contributor
Author
There was a problem hiding this comment.
This branch of logic was missing to handle upstream interfaces to nodegraphs.
| uiNode->getOutput()->setConnectedNode(_currUiNode->getNode()); | ||
| // Is an output port | ||
| mx::OutputPtr outputPtr = uiNode->getOutput(); | ||
| if (outputPtr) |
Contributor
Author
There was a problem hiding this comment.
Firewall check if no outputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes: #2815
Note: Does not fix all related issues but prevents data loss and crashing.
Example:
It is possible to connect a root input to a downstream nodegraph and rename -- in this case the default loaded Marble graph.