fix: Allow wallet iframe storage access#36
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
coffeexcoin
changed the title
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Storage Access API permissions needed for the wallet-host iframe to request access to its own unpartitioned cookies/storage while embedded in a third-party dApp.
The SDK iframe sandbox now includes
allow-storage-access-by-user-activation, and the iframeallowattribute grantsstorage-accessto the wallet host origin. This does not expose wallet cookies to the embedding dApp; it only allows the wallet document to request access to its own storage under browser third-party-cookie policies.Validation
pnpm --filter @abstract-foundation/wallet-sdk testpnpm --filter @abstract-foundation/wallet-sdk typecheckpnpm exec biome check packages/wallet-sdk/src/core/Dialog.ts packages/wallet-sdk/test/src/Dialog.test.ts