Full support for Rocq 9.2#587
Open
xavierleroy wants to merge 9 commits into
Open
Conversation
The `coq` commands are not available for Rocq >= 9.2. In configure, detect whether `rocq` or `coq` is to be used.
Also: install `rocq` package; `coq` is no longer needed nor available.
`Create Rewrite Hintdb` is not available before 9.2, so we don't use it yet. This seems to make the TailNoLabel tactic more powerful, simplifying the proofs in RISC-V Asmgenproof.
The powers that be decided to deprecate `Proof (term)` without reason. Nonetheless, `Proof. exact (term). Qed.` looks nicer when rendered with `coq2html`.
As suggested by warning `postfix-notation-not-level-1` in Rocq 9.2.
This causes Rocq to try to autogenerate a rewriting scheme, which is useless here and causes a warning in Rocq 9.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the new warnings introduced by Rocq 9.2, either by rewriting the Rocq code in the new recommended way, or by silencing the warning.
It also changes the configure and build system so that the
rocqcommand is used directly when available. This makes it possible to build CompCert if Rocq is installed but the Coq-compatibility package is not.It also declares OCaml 5 as officially supported, since we had no problems in testing and OCaml 5 is now fully supported by Rocq.