Fix #35: Clarify palette modification persistence #40
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 15, 2026 18:32
…ghtness command The command list table incorrectly showed that Get Display Brightness (0x09) does not send a reply. This commit fixes the table to correctly indicate that the command does send a reply, matching the command description.
Add a note explaining how to retrieve the complete default RGB color palette (all 128 entries from index 0 to 127) using the Get LED Color Palette Entry sysex command (0x04). This addresses the request to document the full palette beyond the subset currently shown in the documentation.
Add a note clarifying that in User mode, MIDI system real time messages (start, stop, continue, clock) must be sent on Port 2, as Port 1 messages are ignored. This explains why animations may not run at the default 120 bpm tempo in User mode when no MIDI start message has been received on the active port.
…palette indices Add a new section explaining how to convert arbitrary RGB color values to the closest Push 2 color palette index. This includes: - Instructions for retrieving the complete palette - Distance calculation methods (Euclidean and perceptual) - Alternative approach of modifying the palette with custom colors This addresses the question about translating Max For Live colors to Palette Color Index values.
Add link to push2_display crate on crates.io as mentioned in issue Ableton#29. This provides a Rust implementation for the Push 2 display interface.
Add a note clarifying that palette modifications made using 'Set LED Color Palette Entry' command are temporary and reset on reboot. This matches the clarity provided in the White Balance section and helps users understand the behavior of palette modifications. This addresses the documentation gap where users might assume palette changes are persistent, similar to how white balance has both temporary and persistent (flashed) options.
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #35 by clarifying that color palette modifications are temporary and reset on device reboot. The changes add comprehensive documentation about RGB color palette usage, including conversion methods and persistence behavior.
Changes:
- Added NOTE clarifying palette modifications are temporary and not persisted to flash memory
- Added new section explaining how to convert RGB values to palette indices
- Added NOTE explaining the default color palette table is a subset
- Added NOTE about MIDI system real time messages in User mode
- Added link to Rust display driver in README
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| doc/AbletonPush2MIDIDisplayInterface.asc | Added documentation clarifying palette modification persistence, RGB conversion methods, MIDI message routing, and fixed table formatting |
| README.md | Added link to Rust display driver library |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a note clarifying that palette modifications made using "Set LED Color
Palette Entry" command are temporary and reset on reboot.
Changes:
Files Changed:
Ready for squash-and-merge.