Fix #26: Add clarification about User mode animation timing #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a note clarifying that in User mode, MIDI system real time messages (start, stop, continue, clock) must be sent on Port 2, as Port 1 messages are ignored. This explains why animations may not run at the default 120 bpm tempo in User mode when no MIDI start message has been received on the active port.
There was a problem hiding this comment.
Pull request overview
This PR adds documentation to clarify animation timing behavior in User mode, addressing issue #26 where animations appear static when Live is stopped and Push 2 is in User mode.
Changes:
- Added a NOTE section explaining that MIDI system real time messages must be sent on Port 2 in User mode
- Clarified that animations may not run at the default 120 bpm tempo in User mode without a MIDI start message
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #26: Animations not running correctly in User mode
Adds a note clarifying that in User mode, MIDI system real time messages
must be sent on Port 2, as Port 1 messages are ignored. This explains why
animations may not run at the default 120 bpm tempo in User mode.
Changes:
Files Changed:
Ready for squash-and-merge.