Skip to content

Bugfix/add validation for password#63

Open
PVASH1070091-O wants to merge 7 commits intoAbhilashK26:mainfrom
PVASH1070091-O:bugfix/AddValidationForPassword
Open

Bugfix/add validation for password#63
PVASH1070091-O wants to merge 7 commits intoAbhilashK26:mainfrom
PVASH1070091-O:bugfix/AddValidationForPassword

Conversation

@PVASH1070091-O
Copy link
Copy Markdown

This is a template on how to fill out a PR properly.

Pull Request Template

Thank you for your contribution to CodeBase! Please provide the following information to help us review your pull request.

Description

Please fill out the description box below:

  • Language Used: JavaScript
  • Approach Used: I have used regex to add validation
  • Question(s) Solved:
  • Issue(s) related:

Please describe the changes you have made in this pull request. Include any relevant context or details.

  • What does this PR fix or add? - This is a fix PR
  • Are there any dependencies or related issues? - No
  • Any special instructions for testing? - No

Type of Change

Please select the appropriate option by putting x (example- [x]):

  • [ * ] Bug fix
  • New feature
  • Refactoring
  • Documentation update

Checklist

  • [ * ] I have tested my changes locally.
  • I have added any necessary tests.
  • I have updated the documentation (if applicable).
  • [* ] I have followed the coding style of the project.
  • [ *
Screenshot 2024-12-19 at 12 54 38 AM ] My code is ready for review.

Screenshots/video

Please include screenshots or video to help us identifying the solved issues.


We will review your changes and get back to you soon. Thank you for contributing to CodeBase!

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codebase_client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 5:50pm

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 18, 2024

@RohitP2005 is attempting to deploy a commit to the Abhilash Kumar's projects Team on Vercel.

A member of the Team first needs to authorize it.

@RohitP2005
Copy link
Copy Markdown
Contributor

@AbhilashK26 is there anything that needs to bone for merging

@AbhilashK26
Copy link
Copy Markdown
Owner

@AbhilashK26 is there anything that needs to bone for merging

Please read CONTRIBUTING.md.
It is mentioned that first pull from main then resolve merge conflict and commit again if there was any merge conflict. Then push your changes and make the pull request.
Your recent pull request shows some changes that has already been merged to main.

@PVASH1070091-O
Copy link
Copy Markdown
Author

What should i do now, do i need to raise another pr or create seperate branch and then create the pr

@MegaReXR
Copy link
Copy Markdown
Collaborator

No you just commit your change then pull the main again if any conflicts happen resolve them then after resolving make a resolve commit and make the pull request as before from the same branch.

@AbhilashK26
Copy link
Copy Markdown
Owner

Do one successful registration with multiple skills selected and share the screenshot of the register page with data filled and the view profile page of the registered user.

@AbhilashK26
Copy link
Copy Markdown
Owner

Also pull from main branch as main branch is changed recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants