-
Notifications
You must be signed in to change notification settings - Fork 15
feat: better devexp with pre-commit hooks and github actions #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Looks good, but I don't really get the changes of the HTTP status types (from literal to int). Why? |
|
For some reason, linter was not really happy about those literals, but you could keep it and ignore the linter error. If you go back to the literal implementation and execute the pre-commit checks, you will see that mypy will complain about it. |
|
I think it'd be better, tbh |
|
It is certainly cleaner for us humans, I can revert these changes and ignore the linter errors for the sake of readability. What do you think? |
|
I think it would be nice! |
|
Done, @JoaquimCassano So I was able to still use the literals and ensure code quality checks with Mypy without ignoring the linter errors, which is way better. Note: Also those weird changes on other files were not done by hand, they were caused by Ruff formatting |
Summary
This PR introduces pre-commit hooks to improve code quality and automate testing in the development workflow.
Changes Made
Pre-commit Hook Setup:
Documentation Updates:
CI/CD Integration:
Code Quality Fixes: