Skip to content

⚡ Optimize library update performance with parallel requests #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aatricks merged 1 commit into from
Feb 6, 2026
+37 −20
Merged

⚡ Optimize library update performance with parallel requests #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 37 additions & 20 deletions app/src/main/java/io/aatricks/novelscraper/data/repository/LibraryRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,16 @@ import io.aatricks.novelscraper.data.model.ReadingMode
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.async
import kotlinx.coroutines.awaitAll
import kotlinx.coroutines.coroutineScope
import kotlinx.coroutines.launch
import kotlinx.coroutines.flow.*
import kotlinx.coroutines.withContext
import kotlinx.coroutines.sync.Mutex
import kotlinx.coroutines.sync.Semaphore
import kotlinx.coroutines.sync.withLock
import kotlinx.coroutines.sync.withPermit
import java.util.UUID
import javax.inject.Inject
import javax.inject.Singleton
Expand Down Expand Up @@ -313,30 +318,42 @@ class LibraryRepository @Inject constructor(
runCatching("Refresh updates failed") {
val allItems = libraryDao.getAllItems().firstOrNull() ?: emptyList()
val groupedItems = getGroupedByTitle(allItems)

for ((baseTitle, items) in groupedItems) {
if (items.isEmpty()) continue
val latestInLibrary = items.last()
if (latestInLibrary.baseNovelUrl.isBlank() || latestInLibrary.sourceName.isBlank()) continue

runCatching("Failed to refresh updates for $baseTitle") {
val details =
exploreRepository.getNovelDetails(latestInLibrary.baseNovelUrl, latestInLibrary.sourceName)
if (details != null && details.chapters.isNotEmpty()) {
val sourceChapterCount = details.chapters.size
if (sourceChapterCount > latestInLibrary.totalChapters) {
val itemToMark = items.find { it.isCurrentlyReading } ?: latestInLibrary
val updatedItems = items.map { item ->
var newItem = item.copy(totalChapters = sourceChapterCount)
if (item.id == itemToMark.id && !item.hasUpdates) {
newItem = newItem.copy(hasUpdates = true)
val semaphore = Semaphore(5)

coroutineScope {
groupedItems.map { (baseTitle, items) ->
async {
semaphore.withPermit {
if (items.isNotEmpty()) {
val latestInLibrary = items.last()
if (latestInLibrary.baseNovelUrl.isNotBlank() && latestInLibrary.sourceName.isNotBlank()) {
runCatching("Failed to refresh updates for $baseTitle") {
val details =
exploreRepository.getNovelDetails(
latestInLibrary.baseNovelUrl,
latestInLibrary.sourceName
)
if (details != null && details.chapters.isNotEmpty()) {
val sourceChapterCount = details.chapters.size
if (sourceChapterCount > latestInLibrary.totalChapters) {
val itemToMark =
items.find { it.isCurrentlyReading } ?: latestInLibrary
val updatedItems = items.map { item ->
var newItem = item.copy(totalChapters = sourceChapterCount)
if (item.id == itemToMark.id && !item.hasUpdates) {
newItem = newItem.copy(hasUpdates = true)
}
newItem
}
libraryDao.insertItems(updatedItems)
}
}
}
}
newItem
}
libraryDao.insertItems(updatedItems)
}
}
}
}.awaitAll()
}
}
}
Expand Down