Skip to content

🔒 Security Fix: Remove insecure 'Ignore SSL Errors' option#28

Merged
Aatricks merged 1 commit intomainfrom
security-fix-ssl-vuln-860067918690827876
Feb 6, 2026
Merged

🔒 Security Fix: Remove insecure 'Ignore SSL Errors' option#28
Aatricks merged 1 commit intomainfrom
security-fix-ssl-vuln-860067918690827876

Conversation

@Aatricks
Copy link
Owner

@Aatricks Aatricks commented Feb 6, 2026

This PR addresses a critical security vulnerability by removing the "Ignore SSL Errors" feature.
Previously, the app allowed users to disable SSL certificate validation, which could be exploited to intercept secure traffic.

Changes:

  1. NetworkModule.kt: Removed the insecure TrustManager and HostnameVerifier logic. The OkHttpClient now uses the system's default secure configuration.
  2. PreferencesManager.kt: Removed the ignoreSslErrors property and storage key.
  3. BaseJsoupSource.kt: Removed the logic that created an insecure SSLContext based on the preference.
  4. UI Removal: Removed the "Settings" dialog and switch from the Library drawer (LibraryDrawerContent.kt) and the corresponding state in LibraryViewModel.kt.
  5. ReaderScreen.kt: Updated CloudflareDialog to rely on standard WebView SSL handling (which blocks invalid certs by default).
  6. Testing: Added LibraryViewModelTest.kt to ensure the ViewModel remains stable after removing the dependency. Validated with existing unit tests.

Risk Assessment:

  • Risk: High (Man-in-the-Middle attacks) if the feature was enabled.
  • Fix: Complete removal of the unsafe functionality.
  • Impact: Users on networks with captive portals or invalid certificates will no longer be able to bypass the error within the app, which is the intended secure behavior.

PR created automatically by Jules for task 860067918690827876 started by @Aatricks

- Removed custom TrustManager and HostnameVerifier in NetworkModule.kt that allowed bypassing SSL validation.
- Removed `ignoreSslErrors` preference from PreferencesManager.kt and associated UI in LibraryDrawerContent.kt.
- Cleaned up BaseJsoupSource.kt and ReaderScreen.kt to use standard secure connections.
- Added LibraryViewModelTest.kt to verify ViewModel integrity.

This fixes a security vulnerability where SSL validation could be disabled, exposing users to MITM attacks.

Co-authored-by: Aatricks <113598245+Aatricks@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Aatricks Aatricks merged commit ea6d476 into main Feb 6, 2026
1 check passed
@Aatricks Aatricks self-assigned this Feb 6, 2026
@Aatricks Aatricks deleted the security-fix-ssl-vuln-860067918690827876 branch February 6, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant