Skip to content

Ssl ignore#23

Merged
Aatricks merged 2 commits intomainfrom
ssl-ignore
Jan 16, 2026
Merged

Ssl ignore#23
Aatricks merged 2 commits intomainfrom
ssl-ignore

Conversation

@Aatricks
Copy link
Owner

This pull request introduces a new user-configurable option to ignore SSL errors, refactors network and source handling to support this feature, and improves referer handling for specific sources. It also adds a settings dialog to the UI, allowing users to toggle SSL error ignoring. Additionally, a new enum for sorting modes is introduced.

SSL Error Handling and Preferences

  • Added a new ignoreSslErrors Boolean property to PreferencesManager, persisted via shared preferences, along with its key. This allows the app to remember the user's choice regarding SSL error handling. [1] [2]
  • The OkHttp client in NetworkModule is now built to dynamically respect the ignoreSslErrors preference, using a custom trust manager and hostname verifier. If enabled, SSL errors are ignored globally for network requests.
  • The BaseJsoupSource and its inheritors (MangaBatSource, NovelFireSource) are refactored to accept PreferencesManager and OkHttpClient via dependency injection, and now use the new SSL error handling logic when making network requests. [1] [2] [3] [4] [5] [6] [7] [8]

UI Enhancements

  • Added a settings dialog accessible from the library drawer, allowing users to toggle the "Ignore SSL Errors" option. The dialog explains the risks of enabling this feature. [1] [2] [3] [4] [5]

Referer Handling Improvements

  • Improved referer logic for MangaBat/Manganato images and requests, setting a specific referer when required for these sources, both in the repository and image loading components. [1] [2]

Other Changes

  • Introduced a new SortMode enum to support sorting by last read, date added, title, or progress.
  • Minor import and dependency injection updates to support the above changes.

These updates make the app more robust in environments with problematic SSL certificates and improve user experience when accessing certain sources.

@Aatricks Aatricks self-assigned this Jan 16, 2026
@Aatricks Aatricks merged commit d16c654 into main Jan 16, 2026
1 check failed
@Aatricks Aatricks deleted the ssl-ignore branch January 16, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant