Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new user-configurable option to ignore SSL errors, refactors network and source handling to support this feature, and improves referer handling for specific sources. It also adds a settings dialog to the UI, allowing users to toggle SSL error ignoring. Additionally, a new enum for sorting modes is introduced.
SSL Error Handling and Preferences
ignoreSslErrorsBoolean property toPreferencesManager, persisted via shared preferences, along with its key. This allows the app to remember the user's choice regarding SSL error handling. [1] [2]NetworkModuleis now built to dynamically respect theignoreSslErrorspreference, using a custom trust manager and hostname verifier. If enabled, SSL errors are ignored globally for network requests.BaseJsoupSourceand its inheritors (MangaBatSource,NovelFireSource) are refactored to acceptPreferencesManagerandOkHttpClientvia dependency injection, and now use the new SSL error handling logic when making network requests. [1] [2] [3] [4] [5] [6] [7] [8]UI Enhancements
Referer Handling Improvements
Other Changes
SortModeenum to support sorting by last read, date added, title, or progress.These updates make the app more robust in environments with problematic SSL certificates and improve user experience when accessing certain sources.