fix: improve EPUB image parsing and path resolution#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the EPUB chapter parsing and image handling logic in the
ContentRepository. The main changes make the content extraction more robust, especially for images and nested elements, and improve the way image paths are resolved and matched within EPUB archives.Parsing and content extraction improvements:
traversefunction to better handle nested elements, ensuring both text and images (including those nested inside other tags) are properly extracted and added asContentElements. This also improves direct text extraction from non-standard containers.EPUB image path resolution and matching:
resolveEpubPathfunction to normalize relative paths, correctly handling.and..path segments, preventing issues with image references that use directory traversal.