Open
Conversation
Owner
|
Hey, @somudas your solution seems to fail flutter analyze. Try removing all the errors and then submit again. (Hint: all the warnings displayed in vscode need to be removed, for flutter analyze to pass). |
Owner
|
Hey, tests seem to fail ! I think you have implemented long press to delete a todo, expected was double tap to delete a todo. Run flutter test and resolve the errors ! 😃 |
devansh12b2
requested changes
Feb 10, 2022
Collaborator
devansh12b2
left a comment
devansh12b2
left a comment
There was a problem hiding this comment.
On todo_screen instead of creating a new dialog box try calling widget from add_todo_dialogue
devansh12b2
requested changes
Feb 10, 2022
Collaborator
devansh12b2
left a comment
devansh12b2
left a comment
There was a problem hiding this comment.
Same with displaying todo list try to make it in todo_list_item.dart and then calling it on todo screen
devansh12b2
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.