-
Notifications
You must be signed in to change notification settings - Fork 0
Sync fork with upstream monix/monix:main #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: series/3.x-avs
Are you sure you want to change the base?
Changes from all commits
df4d186
171586d
60eec23
4e92eaf
87d17fd
3344c51
bc2309a
bca654e
e3a7fe6
a15dcd1
ce0a3ce
440f0a6
ee0b8b6
5bac9a1
88fdaf6
ff7a7b0
d68dd0e
4d1a97c
0b7919e
5708f24
1f5d939
3bcd6f6
d770c03
ac5cce1
a43906b
2e9dc85
d6f504a
4823272
0f5bbde
09ad306
1e439b5
f1769c9
aab5173
82fa8f6
23f2276
38f2ce4
b2afd33
a0d2ea6
81f2775
a8f4177
5d732ee
d2f8ed1
72ba954
cf71823
c688df5
518b8da
6aa0350
e11cfad
0df25b6
5393572
de87984
f2cca0d
cf4f1e5
41511b3
629cf79
c1cbf43
88aa30d
dfab0dc
8447616
2faa2cf
9b8d48b
4d76ff9
4358e23
8c00851
201c6bf
f38a4f5
3e74752
240ec65
f4cf169
330fd7d
f7ce85d
13aa053
b15e911
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,9 @@ TAGS | |
| .tags | ||
| .metals | ||
| .bloop | ||
| .bsp | ||
| metals.sbt | ||
| .vscode | ||
| .bsp | ||
| .planning/ | ||
| *.sublime* | ||
| .sisyphus/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| pullRequests.frequency = "7 days" | ||
|
|
||
| updates.pin = [ | ||
| { groupId = "org.typelevel", artifactId="cats-effect", version = "2." }, | ||
| { groupId = "org.typelevel", artifactId="cats-effect-laws", version = "2." }, | ||
| ] | ||
| #updates.pin = [ | ||
| # { groupId = "org.typelevel", artifactId="cats-effect", version = "2." }, | ||
| # { groupId = "org.typelevel", artifactId="cats-effect-laws", version = "2." }, | ||
| #] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Agent Instructions for Monix | ||
|
|
||
| This file contains mandatory rules for AI agents (Copilot, Claude, Cursor, etc.) working on this repository. | ||
| **Any violation is a CI-breaking mistake!** | ||
|
|
||
| --- | ||
|
|
||
| ## Code rules | ||
|
|
||
| - Never workaround the compiler, make an effort to solve errors in an idiomatic way: | ||
| - Avoid `asInstanceOf` downcasting, unless there's no other way (e.g., untagged union types in Scala 3). | ||
| - `@nowarn` annotations, or other ways for supressing warnings/errors, are not permitted without the user's consent. | ||
| - We fix warnings, we don't ignore them. | ||
|
Comment on lines
+10
to
+13
|
||
| - Use package imports, instead of fully qualified names. | ||
| - Make an effort to write idiomatic, yet performant Scala code. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow sets up Java 8 (Adopt) even though the PR description and CHANGES indicate JDK 17 is the minimum supported baseline. This will likely fail publishes/builds or (worse) publish artifacts built with the wrong toolchain. Update the workflow to use the project baseline (e.g., Temurin 17) and align the setup-java action version accordingly.