Fix segfault in avs_consume_quotable_token()#307
Open
kemonats wants to merge 1 commit intoAVSystem:masterfrom
Open
Fix segfault in avs_consume_quotable_token()#307kemonats wants to merge 1 commit intoAVSystem:masterfrom
kemonats wants to merge 1 commit intoAVSystem:masterfrom
Conversation
Mierunski
suggested changes
Oct 25, 2021
Mierunski
left a comment
Mierunski
left a comment
There was a problem hiding this comment.
Hi
Thank you for the patch, just a remark
| if (dest_size == 0) { | ||
| dest = NULL; | ||
| } else if (!dest) { | ||
| dest_size = 0; |
There was a problem hiding this comment.
Having null dest pointer with non-zero dest_size looks more like a programming error. It should fire an assertion or error log message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes segfault in avs_consume_quotable_token() if
dest_size > 0 and dest == NULL