Only regenerate ROOT dictionaries when needed#261
Open
anthoak13 wants to merge 1 commit intoATTPC:developfrom
Open
Only regenerate ROOT dictionaries when needed#261anthoak13 wants to merge 1 commit intoATTPC:developfrom
anthoak13 wants to merge 1 commit intoATTPC:developfrom
Conversation
Previously, any change to any header would cause all ROOT dictionaries to be regenerated which can slow down compile time significantly. In addition any time cmake was reconfigured, even if not files were changed all the dictionaries would be regenerated. This commit adds a stamp file to each dictionary which is updated with the last modification time of the headers used to generate the dictionary. It uses hashs to determine the last update time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, any change to any header would cause all ROOT dictionaries to be regenerated which can slow down compile time significantly. In addition any time cmake was reconfigured, even if not files were changed all the dictionaries would be regenerated.
This commit adds a stamp file to each dictionary which is updated with the last modification time of the headers used to generate the dictionary. It uses hashs to determine the last update time.
We also change how the headers are copied in to the build/include folder. Before they were added as dependencies, but now
they are just copied. This could mean that in some edge cases the headers are not copied unless cmake is reconfigured.