Feature/improve id encoding and curated path#20
Merged
Conversation
4 tasks
Alexander-Morin
approved these changes
Apr 23, 2026
| String workflow_name = "spatial_geomx" | ||
| String workflow_version = "v1.0.0" | ||
| String workflow_release = "https://github.com/ASAP-CRN/spatial-transcriptomics-wf/releases/tag/spatial_geomx_analysis-~{workflow_version}" | ||
| String crn_release_version = "v4.0.0" |
There was a problem hiding this comment.
Same question as for the scRNA-seq pipeline, is this supposed to be hard-coded (and just updated per release?)
Collaborator
Author
There was a problem hiding this comment.
Yes, it's helpful to keep the release version and workflow version history in the GitHub repo. It's rare that the pipeline won't need an update when running new datasets, so usually the workflow_version and crn_release_version will both need to be bumped. Also, this is now the new way we'll be storing curated outputs-- in a crn_release_version folder instead of workflow_version folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use "ID" and "name" consistently in pipeline. Change curated output path to be stored under release version folders instead of workflow version folders.
Dependencies (Issues/PRs)
https://app.clickup.com/t/9014209604/BIOS-2080
https://app.clickup.com/t/9014209604/BIOS-2024
Type of Change
Task Checklist
miniwdl checkpassedwomtool validatepassedTesting
Workflow Engine Tested On
Successful Workflow IDs
N/A