Fix Wayland window creation to comply with Weston 15 xdg-shell protocol#69
Open
pleasurefish wants to merge 1 commit into
Open
Fix Wayland window creation to comply with Weston 15 xdg-shell protocol#69pleasurefish wants to merge 1 commit into
pleasurefish wants to merge 1 commit into
Conversation
The previous implementation did not properly follow the xdg-shell configure/commit flow required by Weston 15, causing window creation and resize operations to fail. Changes: - Add xdg_toplevel_listener to handle configure events with width/height parameters - Implement proper configure/ack/commit sequence for window initialization - Add mConfigured flag to track surface configuration state - Wait for configure event before proceeding with window show/resize operations - Move callback function implementations after WaylandWindow class definition to resolve forward declaration issues The correct flow is now: 1. Request state change (set_fullscreen/unset_fullscreen) 2. Commit surface (wl_surface_commit) 3. Wait for configure event from compositor 4. Acknowledge configure (xdg_surface_ack_configure) 5. Proceed with rendering This ensures compatibility with Weston 15's stricter xdg-shell protocol enforcement where surfaces must be configured before they can be displayed. Signed-off-by: Jiyu Yang <jiyu.yang@nxp.com>
Contributor
|
Thanks for your contribution! We will look at it and test it. |
Author
|
thanks for your information, looking forward to your update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation did not properly follow the xdg-shell configure/commit flow required by Weston 15, causing window creation and resize operations to fail.
Changes:
The correct flow is now:
This ensures compatibility with Weston 15's stricter xdg-shell protocol enforcement where surfaces must be configured before they can be displayed.