adding "extern C" guard#1144
Conversation
|
Thanks @CheMax-Tag, may I ask you to update all file versions and dates of files you've touched, please? Cheers, |
|
Ok. I'm sorry, this is essentially the first request in my practice). Another question, the date indicated in the copyright should also be updated?
should I change the year to 2021? |
moving the guard higher, since he fell under the definition.
|
Yes, please change the year to 2021. |
|
Ok, it's ready. |
| ******************************************************************************/ | ||
| /* | ||
| * Copyright (c) 2020 Arm Limited. All rights reserved. | ||
| * Copyright (c) 2021 Arm Limited. All rights reserved. |
There was a problem hiding this comment.
Copyright should state "2020-2021" not just 2021
| ******************************************************************************/ | ||
| /* | ||
| * Copyright (c) 2020 Arm Limited. All rights reserved. | ||
| * Copyright (c) 2021 Arm Limited. All rights reserved. |
There was a problem hiding this comment.
Please change to "2020-2021"
|
Thanks for taking this over and contributing. May I ask you to sqash all your commits into a single one, please? |
Yes, it will take me a while |
|
I'm a little confused with branches collapsing commits. Correct commit with all changes 38236c1 |
|
Hi @CheMax-Tag, no worries. The PR cannot be merged this way. It looks like you introduced a merge commit. Cheers, |
|
Can one of the admins verify this patch? |
c9155d1 to
1b35075
Compare
I add missing "extern C" guard for some header files.
This can help to stub out the error described in #617 when using the C++ compiler.
I plan to check all the headers and add missing guards if you don't mind.