Skip to content

Fix integer overflow in single rounding requantization #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mansnils merged 2 commits into from
May 27, 2026
Merged

Fix integer overflow in single rounding requantization #220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a86cbc
Fixed arm_nn_requantize for single rounding
veblush May 21, 2026
e1620f4
Updated date/revision
veblush May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Include/arm_nnsupportfunctions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
* Title: arm_nnsupportfunctions.h
* Description: Public header file of support functions for CMSIS NN Library
*
* $Date: 6 Mars 2026
* $Revision: V.22.9.0
* $Date: 21 May 2026
* $Revision: V.22.9.1
*
* Target : Arm(R) M-Profile Architecture
* -------------------------------------------------------------------- */
Expand Down Expand Up @@ -1683,7 +1683,7 @@ __STATIC_FORCEINLINE int32_t arm_nn_requantize(const int32_t val, const int32_t
const int64_t total_shift = 31 - shift;
const int64_t new_val = val * (int64_t)multiplier;

int32_t result = new_val >> (total_shift - 1);
int64_t result = new_val >> (total_shift - 1);
Comment thread
mansnils marked this conversation as resolved.
result = (result + 1) >> 1;

return result;
Expand Down