Conversation
Replaced a large config with config for each module.
Injected these configs into implementations and removed redundant storage.
Updated BaseModule wrappers and test fixtures to use the new schemas.
RBhupi
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 18.34% 19.88% +1.54%
==========================================
Files 46 49 +3
Lines 6100 6079 -21
Branches 886 863 -23
==========================================
+ Hits 1119 1209 +90
+ Misses 4869 4761 -108
+ Partials 112 109 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR tags (required)
Select all that apply.
What changed
adapt.contracts, refactored config injection patterns, and cleaned runtime/module dependency structure.Why
As the codebase grows, architectural drift and hidden import coupling become harder to manage. This PR establishes enforceable boundaries, standardized linting, and cleaner packaging/release workflows to improve maintainability, contributor onboarding, and long-term scalability.
Issues closed
Addresses #8
Closes #18
Closes #19
Addresses #9
Target version (required)
Aiming for:
next releaseValidation
I ran ruff
ruff check .— All passI ran import-linter
lint-imports— All passContracts: 7 kept, 0 broken.
N/A reason (if not run):
I ran tests
AI usage & manual verification
git diffReviewer guide
Entry point:
Key files/areas (1-3):
adapt.contractsExpected review time:
Impact note (optional):
This PR has started to enforce architectural boundaries with import-linter.