Skip to content

Conversation

@NullPointer-cell
Copy link

@NullPointer-cell NullPointer-cell commented Jan 19, 2026

Added title attribute 'Search with Face' to Button component

Improves UX consistency with other navigation buttons

Fixes #1042

Signed-off-by: NullPointer-cell
jayantmcom@gamil.com

Summary by CodeRabbit

  • Style
    • Added a tooltip to the face search button to provide clearer guidance about its functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

Added title attribute 'Search with Face' to Button component

Improves UX consistency with other navigation buttons

Fixes AOSSIE-Org#1042

Signed-off-by: NullPointer-cell <jayantmcom@gamil.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

A single line modification adds a title="Search with Face" attribute to the Dialog Trigger Button component in FaceSearchDialog.tsx. This provides a native browser tooltip for the face detection search icon in the navigation bar.

Changes

Cohort / File(s) Summary
UI Accessibility Enhancement
frontend/src/components/Dialog/FaceSearchDialog.tsx
Added title="Search with Face" attribute to the Button component for tooltip display (+1 line)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • PR #576: Adds accessibility improvements to the same FaceSearchDialog trigger button, including title and aria-label attributes for enhanced user experience and screen reader support.

Suggested labels

UI, good first issue

Suggested reviewers

  • rahulharpal1603

Poem

🐰 A tooltip springs to life with ease,
"Search with Face" puts minds at ease,
The icon now speaks its truth so clear,
No more confusion, all users cheer! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'feat: add tooltip to Face Search button' directly and clearly describes the main change: adding a tooltip to the Face Search button.
Linked Issues check ✅ Passed The code change implements the exact requirement from issue #1042: adding title='Search with Face' attribute to the Button component in FaceSearchDialog.tsx.
Out of Scope Changes check ✅ Passed The PR contains only the single, focused change of adding a title attribute to the Face Search button, which is directly aligned with issue #1042 requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NullPointer-cell
Copy link
Author

Hi Hi @Ujjiyara
I've completed issue #1042 and submitted this PR for review. Added the title="Search with Face" attribute as specified - clean, minimal change with proper signoff.
I know you're busy, but would really appreciate your feedback when you get a chance. Thank you for maintaining this project!

@Ujjiyara
Copy link

Hi Hi @Ujjiyara I've completed issue #1042 and submitted this PR for review. Added the title="Search with Face" attribute as specified - clean, minimal change with proper signoff. I know you're busy, but would really appreciate your feedback when you get a chance. Thank you for maintaining this project!

i am myself a contributor and i wanted to work on this issue. you have linked a PR without actual assignment to this issue. If i am not wrong, this isn't allowed according to the rules.

@NullPointer-cell
Copy link
Author

okay sorry for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: Add Tooltip to Face Search Button

2 participants