Prevent integer overflows in src/gainmap.c#3051
Merged
wantehchang merged 1 commit intoAOMediaCodec:mainfrom Feb 24, 2026
Merged
Prevent integer overflows in src/gainmap.c#3051wantehchang merged 1 commit intoAOMediaCodec:mainfrom
wantehchang merged 1 commit intoAOMediaCodec:mainfrom
Conversation
Prevent integer overflows in multiplications involving width, height, and rowBytes in src/gainmap.c by performing the multiplications in the size_t type. The size_t type is large enough because pixel buffers for the width, height, and rowBytes have been allocated successfully. "Dexter.k" <164054284+rootvector2@users.noreply.github.com> reported an integer overflow in the allocation of the gainMapF buffers in avifRGBImageComputeGainMap() and suggested a fix in AOMediaCodec#3049.
Collaborator
Author
|
@rootvector2 Dexter.k: FYI. I wrote this pull request by starting from your pull request #3049. After I discovered that much more changes should be made, I decided to create my own pull request rather than suggest changes to your pull request, and treat your pull request as a bug report. |
maryla-uc
approved these changes
Feb 23, 2026
Contributor
maryla-uc
left a comment
maryla-uc
left a comment
There was a problem hiding this comment.
Thanks a lot for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent integer overflows in multiplications involving width, height, and rowBytes in src/gainmap.c by performing the multiplications in the size_t type. The size_t type is large enough because pixel buffers for the width, height, and rowBytes have been allocated successfully.
"Dexter.k" 164054284+rootvector2@users.noreply.github.com reported an integer overflow in the allocation of the gainMapF buffers in avifRGBImageComputeGainMap() and suggested a fix in #3049.